Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SettingsImporter [4/x] #7853

Merged
merged 4 commits into from
May 21, 2024
Merged

Refactor SettingsImporter [4/x] #7853

merged 4 commits into from
May 21, 2024

Conversation

cketti
Copy link
Member

@cketti cketti commented May 16, 2024

Change the type of SettingsFile.Contents.accounts from Map<String, Account>? to List<Account>.

@cketti cketti requested a review from wmontwe as a code owner May 16, 2024 16:25
wmontwe
wmontwe approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cketti cketti merged commit cd7785f into main May 21, 2024
2 checks passed
@cketti cketti deleted the clean_up_SettingsFileParser_2 branch May 21, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmontwe wmontwe wmontwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cketti @wmontwe