Fix toolbar height in message list #7861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
approved these changes
May 22, 2024
There was a problem hiding this comment.
👍 It fixed the immediate problem of cutting of the subtitle. But we need to discuss with design if it makes sense continuing with it or come of with an alternative solution. With Material 3 the support for a subtitles was droped. That's why they are not going to fix the component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a custom view in the toolbar for the title and the subtitle. This works around a bug in AndroidX's Toolbar implementation: https://issuetracker.google.com/issues/135865267
Depends on #7860
Note: Even when using the default font size this does slightly increase the toolbar height when using a subtitle vs. when not using a subtitle. We could change that by using a value smaller than
@dimen/toolbarTitleMarginVertical.Fixes #7854