Feat: Migrate LiveData to Kotlin Flows #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prakhar-Agarwal-byte
force-pushed
the
mig_flows
branch
from
97c9cda
to
fbdb3ce
Compare
thunderbiscuit
requested changes
Jul 17, 2023
There was a problem hiding this comment.
Thanks for the great work! This is a super old issue and I've been meaning to migrate for over a year. Cheers!
I left a few comments for you. You'll need to rebase on master because I've made many changes, but nothing that should create merge conflicts I don't think.
Can you also explain a bit what the difference is between the Flow and StateFlow? You use one in some cases and the other in other cases. I'd be happy to learn more about when to use which.
app/src/main/java/com/goldenraven/padawanwallet/ui/wallet/WalletViewModel.kt
Show resolved
Hide resolved
thunderbiscuit
force-pushed
the
mig_flows
branch
from
fbdb3ce
to
2f1e11c
Compare
thunderbiscuit
force-pushed
the
mig_flows
branch
from
2f1e11c
to
9e004fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.