-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023-07 - Roots #36
Comments
Hello
I also have some entries to add to the EnuMain dictionary file as well. They are below.
Lastly, I have entries for the abbreviation dictionary. Here they are.
/ |
@mad-gamer13 Please edit your comment to wrap each block of dictionary entries in a code fence, ```, because at the moment we cannot easily select them to add thanks to markdown ignoring newlines in non-code blocks. You could also try a pull request, although note that due to the case of the B actually mattering and eloquence not supporting that we'll probably exclude the abbreviation entries. Those are better done with an NVDA dictionary entry. Finally, we do have at least some of the forms of nvdaremote, although all-caps is not needed as no one actually writes it that way. Initial capital is probably needed, though. |
How exactly do I wrap blocks of code? Do I put 3 grave accents at the beginning and end of code? |
@mad-gamer13 Thanks. I'm working on the entries and will comment once I send the commit. |
@mad-gamer13 Thanks again. I added many of your suggested entries to Root and Main, and as suggested by @ultrasound1372, the 2-letter entries for ENUabbr might mess around with other words, so they haven't been added.
|
Requests Roots:
Main:
Note: The entry for "Fmpeg", with a single f, in main is intended to be for "FFmpeg", with NVDA's cammel case splitting behaviour taken into account ("FFmpeg" gets split as "F Fmpeg"). |
Missing tab on mpeg. I think opensource and possible variations, which is probably only opensourced and maybe opensourcing which would have to be separate anyway, should be put in main, as there is a word boundary here. In either case the second syllable should probably be with a capital X, as used in the default pronunciation of open. Furthermore, I think the main form Ffmpeg, with two f's but only one capital, should be excluded as it's an incorrect form that one is not likely to encounter. Finally, would you also want a main entry for MPEG, in all caps, to be pronounced like this root entry, as is the case for JPEG? Or should the capitalized forms be spelled out, in which case JPEG should be removed? |
@nicopn Thanks. I just added your suggestions as part of the latest commit, and made a couple of minor changes in them. Also added the uppercase "MPEG" to Main to match the lowercase one. |
Requests:
|
@nicopn Where have you encountered mondevol? I agree with most of these but looking at the transcription of that it looks like the last syllable should be given secondary stress. |
@ultrasound1372 Mondevol is the name of a Manamon, which is pronounced as I transcribed. Now that I think about it, the last cyllable should be given secondary stress. I've edited my previous comment to acount for this. |
@nicopn Thanks - I just added these with the latest commit. |
Requests:
|
@amirsol81 What's with severus? Looking at the entries it's surrounded by it appears to have come in from some other list. For the Harry Potter character, I think the pronunciation would either be
or
Adding secondary stress seems to break it strangely. I've heard it pronounced the second way in the films but perhaps for an American pronunciation the first would be acceptable? The first is what the engine gives by default with no dictionary in place. |
@ultrasound1372 The word "severus" was added to cover the following biographical name: Lucius Septimius severus: https://www.merriam-webster.com/dictionary/Severus |
@ultrasound1372 The default pronunciation for the word "advertisement," |
@amirsol81 Oh I see what happened, I was using elocutor as a test but it had a previous copy of the dictionary. You are correct. |
Se Readme for contributing guidelines.
The text was updated successfully, but these errors were encountered: