Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Show diff info #4

Merged
merged 4 commits into from
Feb 10, 2017
Merged

Show diff info #4

merged 4 commits into from
Feb 10, 2017

Conversation

Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Feb 9, 2017

image

Notice

有一个与 mocha 不一样的行为

assert.deepEqual({a: undefined, b: 1}, { b: 1})

这种断言错误在 mocha 中的输出为空,因为在 stringify 的时候 value 为 undefined 的 key 被丢弃了。
这个 pr 中,如果发现这种情况,则输出 Object.keys()diff: https://github.com/thunks/tman/pull/4/files#diff-5c8a5788ecd4b4af2a29bc27ac4ae986R152

@coveralls
Copy link

coveralls commented Feb 9, 2017

Coverage Status

Coverage decreased (-6.7%) to 83.39% when pulling 9471c43 on Brooooooklyn:show-diff-info into a13d861 on thunks:master.

@coveralls
Copy link

coveralls commented Feb 9, 2017

Coverage Status

Coverage increased (+2.3%) to 92.347% when pulling 18fe0da on Brooooooklyn:show-diff-info into a13d861 on thunks:master.

@zensh
Copy link
Member

zensh commented Feb 9, 2017

tman --reporter dot test/cli/reporters.js 有问题。
之前不同的 reporter 模板对 error 的输出是不同的,现在整成同一个感觉也不太搭

@zensh
Copy link
Member

zensh commented Feb 9, 2017

我觉得对 spec 模板启用 diff 就好了,dotbase 还是保持原样,它们的输出格式是各有用途的

@Brooooooklyn
Copy link
Member Author

master 上的 tman --reporter dot test/cli/reporters.js 就是挂的。。。
格式问题可以再调整一下,没有 diff 信息实在是太难用了

@zensh
Copy link
Member

zensh commented Feb 9, 2017

这个是专门用来测试不同模板的错误信息的,当然是“挂”的,我意思是print error 出问题了

@Brooooooklyn
Copy link
Member Author

dot 模式下信息输出错乱的问题解决了
看了一下风格并没有不搭
image

@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage increased (+2.3%) to 92.399% when pulling 15b21f3 on Brooooooklyn:show-diff-info into a13d861 on thunks:master.

@Brooooooklyn
Copy link
Member Author

在本地的 teambition-sdkreactivedb 项目中安装了这个版本的 tman,测试都是正常工作的

@zensh zensh merged commit 64fa59e into thunks:master Feb 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants