Set-Secret - removed call to public function

thycotic-ps · Apr 4, 2021 · dab8048 · dab8048
1 parent ee188be
commit dab8048
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 4 deletions.
diff --git a/src/functions/secrets/Set-Secret.ps1 b/src/functions/secrets/Set-Secret.ps1
@@ -217,14 +217,14 @@ function Set-Secret {
                         $getParams.Add('TicketSystemId', $TicketSystemId)
                         $getParams.Add('Comment', $Comment)
                     }
-                    if (-not $PSCmdlet.ShouldProcess("SecretId: $secret", "Calling Get-TssSecret with keys:`n $($getParams.Keys)`n and values: $($getParams.Values)")) {
+                    if (-not $PSCmdlet.ShouldProcess("SecretId: $secret", "Getting Secret")) {
                         $whatIfProcessing++
                     }
 
                     if ($whatIfProcessing -eq 0) {
                         try {
-                            Write-Verbose "Calling Get-TssSecret with:`t$($getParams)`n"
-                            $getSecret = Get-TssSecret @getParams
+                            Write-Verbose "Getting SecretID: [$secret]"
+                            $getSecret = . $GetSecret $TssSession $secret $restrictedParams
                         } catch {
                             Write-Error "Issue getting Secret [$secret] details: $_"
                         }
@@ -238,7 +238,7 @@ function Set-Secret {
                             }
 
                             if ($setSecretParams.ContainsKey('AutoChangeEnabled')) {
-                                $getSecret.AutoChangeEnabled = $AutoChangeEnabled
+                                $getSecret.AutoChangeEnabled = [boolean]$AutoChangeEnabled
                             }
                             if ($setSecretParams.ContainsKey('AutoChangeNextPassword')) {
                                 if ($setSecretParams.ContainsKey('AutoChangeEnabled') -and -not $AutoChangeEnabled) {

diff --git a/src/parts/GetSecret.ps1 b/src/parts/GetSecret.ps1
@@ -0,0 +1,58 @@
+[cmdletbinding(DefaultParameterSetName = 'secret')]
+param(
+    [Parameter(Mandatory,Position = 0)]
+    [TssSession]
+    $TssSession,
+
+    [Parameter(Mandatory,Position = 1)]
+    [Alias("SecretId")]
+    [int]
+    $Id,
+
+    [Parameter(Mandatory,Position = 2)]
+    $RestrictedParams
+)
+begin {
+    $invokeParams = . $GetInvokeTssParams $TssSession
+}
+
+process {
+    $restResponse = $null
+    $uri = $TssSession.ApiUrl, 'secrets', $Id -join '/'
+
+    $getSecretBody = @{}
+    if ($restrictedParams.Count -gt 0) {
+        switch ($tssParams.Keys) {
+            'Comment' { $getSecretBody.Add('comment', $Comment) }
+            'ForceCheckIn' { $getSecretBody.Add('forceCheckIn', [boolean]$ForceCheckIn) }
+            'TicketNumber' { $getSecretBody.Add('ticketNumber', $TicketNumber) }
+            'TicketSystemId' { $getSecretBody.Add('ticketSystemId', $TicketSystemId) }
+            'DoublelockPassword' {
+                $passwd = [Runtime.InteropServices.Marshal]::PtrToStringAuto([Runtime.InteropServices.Marshal]::SecureStringToBSTR($DoublelockPassword))
+                $getSecretBody.Add('doubleLockPassword',$passwd)
+            }
+        }
+
+        $uri = $uri, 'restricted' -join '/'
+        $invokeParams.Uri = $uri
+        $invokeParams.Method = 'POST'
+        $invokeParams.Body = $getSecretBody | ConvertTo-Json
+    } else {
+        $uri = $uri
+        $invokeParams.Uri = $uri
+        $invokeParams.Method = 'GET'
+    }
+
+    Write-Verbose "$($invokeParams.Method) $uri with:`t$($invokeParams.Body)`n"
+    try {
+        $restResponse = . $InvokeApi @invokeParams
+    } catch {
+        Write-Warning "Issue getting secret [$secret]"
+        $err = $_
+        . $ErrorHandling $err
+    }
+
+    if ($restResponse) {
+        $restResponse
+    }
+}