Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit testing #43

Open
thygesteffensen opened this issue Mar 1, 2021 · 1 comment
Open

Improve unit testing #43

thygesteffensen opened this issue Mar 1, 2021 · 1 comment

Comments

@thygesteffensen
Copy link
Owner

Make it easier to assert with actions that have been called and what their input parameters (parsed) were.
Think about configuring this after/before building the service provider.

Idea:
Log each action triggers and log the inputs. This should be returned from the Trigger() function, making it easy to assert if an action has been called and assert the input.

Thus separating action executors and asserts.
@thygesteffensen
Copy link
Owner Author

Maybe we will need the output too? No harm in adding it.

And make this configurable, to save memory and make it efficient?

thygesteffensen added a commit that referenced this issue Mar 1, 2021
@thygesteffensen
feat!: Added flow result
ed74956 
When triggering a flow, the function returns and FlowResult instead of just a Task. It is now supposed to be easier to write general action executors and asserting a flow inside the unit test, instead of in the action executors.

#43
This was referenced Mar 1, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thygesteffensen