Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dialect for the execution of SQL sentences #36

Closed
danielfernandez opened this issue Jul 19, 2012 · 13 comments
Closed

Create dialect for the execution of SQL sentences #36

danielfernandez opened this issue Jul 19, 2012 · 13 comments

Comments

@danielfernandez
Copy link
Member

A new "extras" dialect could be created for executing SQL sentences directly from the templates, à la JSP's "sql" taglib.

This is weird and goes against all rules of good software architecture, but could be handy for some users (or for extremely-easy prototyping)

@ultraq
Copy link
Member

ultraq commented Apr 1, 2014

lol, can we close this one? It is very weird, and something that nobody has really asked for :) Just because JSP does it, doesn't mean we should.

@jmiguelsamper
Copy link
Member

Nowadays, that dialect should run JPQL more than SQL.

Anyway, I agree, I've never heard of anyone using the JSTL SQL taglib.

@danielfernandez
Copy link
Member Author

A decade ago, I collaborated with a paint-by-numbers web site called griddlers.net, which at the time was entirely developed using plain JSPs executing SQL queries with the JSTL SQL taglib :-) Code was immensely dirty, I admit, but the whole thing worked, was incredibly fast and allowed a really surprising amount of load, even if directly served by a single Tomcat instance of the time.

And think of all the PHP sites out there that basically do the same...

So yes, you are right, this probably hurts the eye a bit... but some people do these things, and together with #35 it might even be something useful in some scenarios... So why not let someone contribute it? ;)

@ultraq
Copy link
Member

ultraq commented Apr 1, 2014

Yeah, SQL in templates is a very PHP thing. Still, I'd rather someone else do it and not fill our issues/backlog with things we're unlikely to do ourselves :P

@jmiguelsamper
Copy link
Member

Just as a pastime, the SQL dialect has been created at https://github.com/jmiguelsamper/thymeleaf-extras-sqldialect

@ultraq
Copy link
Member

ultraq commented Dec 3, 2015

Ah I remember this one 😃 (I've been browsing some of our old but open issues) Is this, and #35, still something we want to see through to official-ish status?

@danielfernandez
Copy link
Member Author

In this case of SQL querying it would be perfectly fine (actually, probably better) to have an external dialect, created by someone and not an official extras extension. For #35 I'm not that sure… but of course it would be great if someone developed it, official or not ;)

@jmiguelsamper
Copy link
Member

@danielfernandez What do you mean by "it would be great if someone developed it"? Do you want https://github.com/jmiguelsamper/thymeleaf-extras-sqldialect to be ported to 3.0? Or do you want to be published in a more official way?

@danielfernandez
Copy link
Member Author

@jmiguelsamper I was actually talking about #35, without remembering that @ultraq had actually developed it :-(.

Anyway, in both cases (your SQL and @ultraq 's servlet extensions), shouldn't they go to the ecosystem page on the website? Any reasons to not do so?

@jmiguelsamper
Copy link
Member

The reason I did not promote it is that I see it more like a game/proof of concept/example that something that could interest anyone. But I am OK if you prefer to promote it.

@danielfernandez
Copy link
Member Author

@jmiguelsamper I would be fine with listing it at the ecosystem, but it's your decision. It's you who'll have to answer support tickets ;)

@jmiguelsamper
Copy link
Member

Added to ecosystem page. I think this issue can be close.

@ultraq
Copy link
Member

ultraq commented Dec 5, 2015

And time to update them for Thymeleaf 3.0 and publish to Maven :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants