Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot support #23

Closed
thymikee opened this issue Apr 22, 2017 · 4 comments
Closed

Add snapshot support #23

thymikee opened this issue Apr 22, 2017 · 4 comments

Comments

@thymikee
Copy link
Owner

📸
@thymikee thymikee mentioned this issue Apr 22, 2017
Merged
@intellix
Copy link
Contributor

intellix commented Apr 23, 2017 •
edited
Loading

Noticed that the angular version is within the snapshots and imagine it'll cause all snapshots to break each major/minor/bugfix version bump. Is it worth hacking away that attribute?

When Angular is updated, do you just remove your snapshot folder and let it take another?

<div
   id="root1"
   ng-version="4.0.1">

@thymikee
Copy link
Owner Author

You never remove snapshots folder manually. It should always be handled by Jest. I think we're good to remove the ng-version attribute though 👍

@thymikee thymikee mentioned this issue Apr 23, 2017
Closed
@jblankenhorn
Copy link

@thymikee sorry for the question, but is this already released to npm?

@thymikee
Copy link
Owner Author

Yes! It's version 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jblankenhorn @intellix @thymikee