feat: jsdom-v13 #229
Merged
feat: jsdom-v13 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Feb 16, 2019
|
LGTM 👍 |
This enables us to use `localStorage` and `sessionStorage` without mocking it manually. Instructions to handle node < v6 were added to README.md.
|
In latest commit:
|
ahnpnl
approved these changes
Feb 16, 2019
thymikee
approved these changes
Feb 16, 2019
|
Thanks @wtho! Releasing new v7 beta in a minute |
thymikee
pushed a commit
that referenced
this pull request
Feb 16, 2019
This PR introduces jsdom v13 as default test environment for jest-preset-angular. This is achieved by * Adding [jest-environment-jsdom-thirteen](https://github.com/theneva/jest-environment-jsdom-thirteen) as dependency * Adding `testEnvironment: 'jest-environment-jsdom-thirteen' to `jest-preset.js` * Removing Web Storage API mocks from `example/jestGlobalmocks.ts` * Adding instructions in README Troubleshooting to configure usage of jsdom v11 (one line in jest configuration) I added tests in a second commit to confirm it works, but I think they do not have to end up in the repository, as they basically test, what is already tested in jsdom itself. Closes #216
|
Available on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces jsdom v13 as default test environment for jest-preset-angular. This is achieved by
testEnvironment: 'jest-environment-jsdom-thirteen' tojest-preset.js`example/jestGlobalmocks.tsI added tests in a second commit to confirm it works, but I think they do not have to end up in the repository, as they basically test, what is already tested in jsdom itself.
Closes #216