Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages #232

Closed
wants to merge 3 commits into from
Closed

Conversation

nettybun
Copy link

@nettybun nettybun commented Jul 14, 2020

Builds OK :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3a40c97a244093cb73545f1866471ac121036036-PR-232

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12f66d65874936375a8d85969ff80a1e1b8623a1: 0.0%
Covered Lines: 236
Relevant Lines: 236

💛 - Coveralls

package.json Outdated Show resolved Hide resolved
@nettybun nettybun requested a review from thysultan July 14, 2020 22:48
package.json Outdated Show resolved Hide resolved
@thysultan
Copy link
Owner

CI job seems to be tripping(though tests pass) https://github.com/thysultan/stylis.js/pull/232/checks?check_run_id=887462067

@nettybun
Copy link
Author

Yeah I don't know why. Maybe you can kick it off again? Does your UI have a rebuild button or anything?

@thysultan
Copy link
Owner

Yes, re-runned, it's related to the coveralls report:

Run coverallsapp/github-action@v1.0.1
Using lcov file: ./coverage/lcov.info
[error] "2020-07-20T04:52:18.840Z"  'error from getOptions'
##[error]Error: Command failed: git cat-file -p 8cf6dfc8db999543d3b7a4da8a6d1d35738be550
fatal: Not a valid object name 8cf6dfc8db999543d3b7a4da8a6d1d35738be550

I wonder if updating it to point to coverallsapp/github-action@master would fix it per https://github.com/coverallsapp/github-action#standard-example though that repo doesn't have a changelog to see if something changed to break it on that end.

@nettybun nettybun closed this Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants