Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-native field to pkg.json #238

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

Andarist
Copy link
Collaborator

@Andarist Andarist commented Sep 4, 2020

fixes #233

It seems that the Metro bundler used by React Native doesn't handle either .mjs nor .cjs - which is somewhat incorrect because files with unknown extensions have always just been loaded as .js in node. Some more info can be found in my comment here as well.

While technically it's not our issue and theirs - it's unknown when this will get fixed on their side and there are React Native consumers confused with this as stylis is not working for them out of the box. I believe that it's best to just fix this on our side for now.

This probably could have also been fixed by reverting this commit: 180b982 . Pick your poison 😉

@coveralls
Copy link

Pull Request Test Coverage Report for Build 98b9e6006050626fafbd53b556af8e42aa75e3d2-PR-238

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 243c495aaef2739037c1559bb2f1092bba2ff25f: 0.0%
Covered Lines: 236
Relevant Lines: 236

💛 - Coveralls

@Andarist
Copy link
Collaborator Author

@thysultan friendly 🏓

@thysultan thysultan merged commit 3d3cba6 into master Sep 14, 2020
@thysultan thysultan deleted the add-react-native-field branch September 14, 2020 22:46
@thysultan
Copy link
Owner

Published patch update to npm. Thanks for the ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.cjs does not work with React Native and/or Expo
3 participants