Fixed an issue with prefixer going into an infinite recursion

[Andarist]

It's something that has been reported here: emotion-js/emotion#2117

Gonna think about a potential fix for this later.

[coveralls]

Pull Request Test Coverage Report for Build 00a729afc4b3893f7f1f2f0a5e5201b82e224521-PR-244

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 762c50a10a4eb0db3f132cc731d96d8c8156c9b6:	0.0%
Covered Lines:	237
Relevant Lines:	237

---

💛 - Coveralls

[Andarist]

not ideal, but introducing a temp is the best I could figure out for this 🤷‍♂️

[thysultan]

return indexof(value, 'stretch') > -1 ? ... : value

[thysultan]

Or you can just copy the fill-available case here

replace(value, /(.+:)(.+)-([^]+)/, '$1' + WEBKIT + '$2-$3' + '$1' + MOZ + '$3') + value

IGNORE

[Andarist]

the indexof approach doesnt work because of this fit-content:
https://github.com/thysultan/stylis.js/blob/9799734dcf2b04c1216818f8b74cba92b6de4f76/test/Prefixer.js#L130

this is actually missing from the comment above case 102:, should be:

// (f)ill-available, (f)it-content

we could try to use match or whatever but I don't think that testing for specific cases is scalable here, Stylis assumes valid input and this is IMHO OK, the goal of this PR to just be a little bit more fault-tolerant

[thysultan]

This should work

// (min|max)?(width|height|inline-size|block-size)
case 8116: case 7059: case 5753: case 5535:
case 5445: case 5701: case 4933: case 4677:
case 5533: case 5789: case 5021: case 4765:
	// stretch, max-content, min-content, fill-available
	if (strlen(value) - 1 - length > 6)
		switch (charat(value, length + 1)) {
			// (f)ill-available, (f)it-content
			case 102: length = charat(value, length + 3)
			// (m)ax-content, (m)in-content
			case 109:
				return replace(value, /(.+:)(.+)-([^]+)/, '$1' + WEBKIT + '$2-$3' + '$1' + MOZ + (length == 108 ? '$3' : '$2-$3')) + value
			// (s)tretch
			case 115:
				return ~indexof(value, 'stretch') ? prefix(replace(value, 'stretch', 'fill-available'), length) + value : value
		}
	break

[Andarist]

Ok, went with that one

[thysultan]

Did you see the case 102: length = charat(value, length + 3) amendment?

[Andarist]

Oh, no - I've focused on the indexof part in a hurry. This is supposed only to compress the code, right? Either way - I've pushed out this change right now.

[thysultan]

LGTM

[Andarist]

Given that the final change is really proposed by you - I'm merging this right away.

[thysultan]

Published v4.0.4 with these last 2 PR's.

Thanks