fix

Signed-off-by: nolouch <nolouch@gmail.com>
ti-chi-bot · Jul 4, 2024 · 4a4c69f · 4a4c69f
1 parent c13a0c7
commit 4a4c69f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/pkg/mcs/resource_manager/server/config.go b/pkg/mcs/resource_manager/server/config.go
@@ -193,11 +193,11 @@ func (c *Config) Parse(flagSet *pflag.FlagSet) error {
 	configutil.AdjustCommandlineString(flagSet, &c.ListenAddr, "listen-addr")
 	configutil.AdjustCommandlineString(flagSet, &c.AdvertiseListenAddr, "advertise-listen-addr")
 
-	return c.Adjust(meta, false)
+	return c.Adjust(meta)
 }
 
 // Adjust is used to adjust the resource manager configurations.
-func (c *Config) Adjust(meta *toml.MetaData, reloading bool) error {
+func (c *Config) Adjust(meta *toml.MetaData) error {
 	configMetaData := configutil.NewConfigMetadata(meta)
 	warningMsgs := make([]string, 0)
 	if err := configMetaData.CheckUndecoded(); err != nil {

diff --git a/tests/pdctl/resourcemanager/resource_manager_command_test.go b/tests/pdctl/resourcemanager/resource_manager_command_test.go
@@ -56,7 +56,7 @@ func (s *testResourceManagerSuite) TearDownSuite() {
 }
 
 func (s *testResourceManagerSuite) TestConfigController() {
-	expectCfg := server.ControllerConfig{}
+	expectCfg := server.Config{}
 	expectCfg.Adjust(nil)
 	// Show controller config
 	checkShow := func() {
@@ -67,7 +67,7 @@ func (s *testResourceManagerSuite) TestConfigController() {
 		actualCfg := server.ControllerConfig{}
 		err = json.Unmarshal(output, &actualCfg)
 		s.Nil(err)
-		s.Equal(expectCfg, actualCfg)
+		s.Equal(expectCfg.Controller, actualCfg)
 	}
 
 	// Check default config
@@ -78,20 +78,20 @@ func (s *testResourceManagerSuite) TestConfigController() {
 	output, err := pdctl.ExecuteCommand(pdctlCmd.GetRootCmd(), args...)
 	s.Nil(err)
 	s.Contains(string(output), "Success!")
-	expectCfg.LTBMaxWaitDuration = typeutil.Duration{Duration: 1 * time.Hour}
+	expectCfg.Controller.LTBMaxWaitDuration = typeutil.Duration{Duration: 1 * time.Hour}
 	checkShow()
 
 	args = []string{"-u", s.pdAddr, "resource-manager", "config", "controller", "set", "enable-controller-trace-log", "true"}
 	output, err = pdctl.ExecuteCommand(pdctlCmd.GetRootCmd(), args...)
 	s.Nil(err)
 	s.Contains(string(output), "Success!")
-	expectCfg.EnableControllerTraceLog = true
+	expectCfg.Controller.EnableControllerTraceLog = true
 	checkShow()
 
 	args = []string{"-u", s.pdAddr, "resource-manager", "config", "controller", "set", "write-base-cost", "2"}
 	output, err = pdctl.ExecuteCommand(pdctlCmd.GetRootCmd(), args...)
 	s.Nil(err)
 	s.Contains(string(output), "Success!")
-	expectCfg.RequestUnit.WriteBaseCost = 2
+	expectCfg.Controller.RequestUnit.WriteBaseCost = 2
 	checkShow()
 }