Skip to content

Commit

Permalink
KVStore: Reduce lock contention in RegionPersister::doPersist (ping…
Browse files Browse the repository at this point in the history
  • Loading branch information
JaySon-Huang committed Dec 26, 2023
1 parent d158474 commit 1bf4654
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions dbms/src/Storages/Transaction/RegionPersister.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ void RegionPersister::doPersist(RegionCacheWriteElement & region_write_buffer, c
{
auto & [region_id, buffer, region_size, applied_index] = region_write_buffer;

std::lock_guard lock(mutex);

if (page_reader)
{
auto entry = page_reader->getPageEntry(region_id);
Expand Down
1 change: 0 additions & 1 deletion dbms/src/Storages/Transaction/RegionPersister.h
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ class RegionPersister final : private boost::noncopyable

NamespaceId ns_id = KVSTORE_NAMESPACE_ID;
const RegionManager & region_manager;
std::mutex mutex;
LoggerPtr log;
};
} // namespace DB

0 comments on commit 1bf4654

Please sign in to comment.