feat: fetch the collaborator list completely

ti-community-infra · Nov 29, 2020 · 79e99d5 · 79e99d5
1 parent bd36051
commit 79e99d5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/api/pull/index.ts b/src/api/pull/index.ts
@@ -82,11 +82,16 @@ export async function listOwners(
     };
   });
 
-  // FIXME: Fetch the collaborator list completely, not pagination
-  const { data: collaboratorInfos } = await github.repos.listCollaborators({
-    owner,
-    repo,
-  });
+  // Notice：The `github.paginate` API loads the next page data against the link attribute in response's header
+  // TODO: Add paginated test case for the listCollaborators API
+  const collaboratorInfos = await github.paginate(
+    github.repos.listCollaborators,
+    {
+      owner,
+      repo,
+    },
+    (res) => res.data
+  );
 
   const collaborators = collaboratorInfos.map((c) => {
     return {

diff --git a/src/config/SigInfoSchema.ts b/src/config/SigInfoSchema.ts
@@ -1,5 +1,6 @@
 export interface ContributorSchema {
   githubName: string;
+  // The optional flag is set for some api returned the contributor without permissions
   permissions?: {
     pull: boolean;
     push: boolean;