Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More friendly reply when a review does not belong to a reviewer or committer #535

Closed
tisonkun opened this issue May 13, 2021 · 1 comment · Fixed by #538
Closed

More friendly reply when a review does not belong to a reviewer or committer #535

tisonkun opened this issue May 13, 2021 · 1 comment · Fixed by #538
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/feature Categorizes issue or PR as related to a new feature.

Comments

@tisonkun
Copy link
Contributor

ti-chi-bot replies @tisonkun: /lgtm is only allowed for the reviewers in list. if I review a pull request where I am not a reviewer or committer.

pingcap/tidb#24463 (comment)

... while the previous ti-sre-bot replies Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.

pingcap/tiflash#1896 (comment)

It should be better if we keep the friendly reply.

cc @hi-rustin
@tisonkun tisonkun added the type/feature Categorizes issue or PR as related to a new feature. label May 13, 2021
@hi-rustin hi-rustin added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed type/feature Categorizes issue or PR as related to a new feature. labels May 13, 2021
@hi-rustin hi-rustin added the type/feature Categorizes issue or PR as related to a new feature. label May 13, 2021
@hi-rustin
Copy link
Contributor

This is a good improvement! Maybe the response to invalid /merge needs to be improved too.

@tisonkun tisonkun mentioned this issue May 13, 2021
Merged
ti-chi-bot pushed a commit that referenced this issue May 13, 2021
@tisonkun
fix: more friendly reply for /lgtm and /merge by contributor without … (
b79eb01 
#538)

…reviewer or committer bit

Signed-off-by: tison <wander4096@gmail.com>

This closes #535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: more friendly reply for /lgtm and /merge by contributor without … tisonkun/tichi
3 participants
@tisonkun @hi-rustin @ti-chi-bot