Skip to content

Commit

Permalink
cherry pick pingcap#24710 to release-4.0
Browse files Browse the repository at this point in the history
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
  • Loading branch information
wjhuang2016 authored and ti-srebot committed May 18, 2021
1 parent 4f31cb4 commit 9195081
Show file tree
Hide file tree
Showing 2 changed files with 144 additions and 0 deletions.
8 changes: 8 additions & 0 deletions session/session.go
Original file line number Diff line number Diff line change
Expand Up @@ -2221,6 +2221,7 @@ var builtinGlobalVariable = []string{
variable.TiDBEnableRateLimitAction,
variable.TiDBMemoryUsageAlarmRatio,
variable.TiDBMultiStatementMode,
<<<<<<< HEAD
}

var (
Expand All @@ -2236,6 +2237,13 @@ func initLoadCommonGlobalVarsSQL() {
}
loadCommonGlobalVarsSQL = "select HIGH_PRIORITY * from mysql.global_variables where variable_name in ('" + strings.Join(vars, quoteCommaQuote) + "')"
})
=======
variable.TiDBEnableExchangePartition,
variable.TiDBAllowFallbackToTiKV,
variable.TiDBEnableDynamicPrivileges,
variable.CTEMaxRecursionDepth,
variable.TiDBDMLBatchSize,
>>>>>>> 44830b917... session: fix dml_batch_size doesn't load the global variable (#24710)
}

// loadCommonGlobalVariablesIfNeeded loads and applies commonly used global variables for the session.
Expand Down
136 changes: 136 additions & 0 deletions session/session_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3612,3 +3612,139 @@ func (s *testSessionSerialSuite) TestParseWithParams(c *C) {
c.Assert(err, IsNil)
c.Assert(sb.String(), Equals, "SELECT 3")
}
<<<<<<< HEAD
=======

func (s *testSessionSuite3) TestGlobalTemporaryTable(c *C) {
tk := testkit.NewTestKitWithInit(c, s.store)
tk.MustExec("create global temporary table g_tmp (a int primary key, b int, c int, index i_b(b)) on commit delete rows")
tk.MustExec("begin")
tk.MustExec("insert into g_tmp values (3, 3, 3)")
tk.MustExec("insert into g_tmp values (4, 7, 9)")

// Cover table scan.
tk.MustQuery("select * from g_tmp").Check(testkit.Rows("3 3 3", "4 7 9"))
// Cover index reader.
tk.MustQuery("select b from g_tmp where b > 3").Check(testkit.Rows("7"))
// Cover index lookup.
tk.MustQuery("select c from g_tmp where b = 3").Check(testkit.Rows("3"))
// Cover point get.
tk.MustQuery("select * from g_tmp where a = 3").Check(testkit.Rows("3 3 3"))
// Cover batch point get.
tk.MustQuery("select * from g_tmp where a in (2,3,4)").Check(testkit.Rows("3 3 3", "4 7 9"))
tk.MustExec("commit")

// The global temporary table data is discard after the transaction commit.
tk.MustQuery("select * from g_tmp").Check(testkit.Rows())
}

type testTxnStateSuite struct {
testSessionSuiteBase
}

func (s *testTxnStateSuite) TestBasic(c *C) {
tk := testkit.NewTestKitWithInit(c, s.store)
tk.MustExec("create table t(a int);")
tk.MustExec("insert into t(a) values (1);")
info := tk.Se.TxnInfo()
c.Assert(info, IsNil)
tk.MustExec("begin pessimistic;")
tk.MustExec("select * from t for update;")
info = tk.Se.TxnInfo()
_, expectedDigest := parser.NormalizeDigest("select * from t for update;")
c.Assert(info.CurrentSQLDigest, Equals, expectedDigest)
c.Assert(info.State, Equals, txninfo.TxnRunningNormal)
c.Assert(info.BlockStartTime, IsNil)
// len and size will be covered in TestLenAndSize
c.Assert(info.ConnectionID, Equals, tk.Se.GetSessionVars().ConnectionID)
c.Assert(info.Username, Equals, "")
c.Assert(info.CurrentDB, Equals, "test")
tk.MustExec("commit;")
info = tk.Se.TxnInfo()
c.Assert(info, IsNil)
}

func (s *testTxnStateSuite) TestEntriesCountAndSize(c *C) {
tk := testkit.NewTestKitWithInit(c, s.store)
tk.MustExec("create table t(a int);")
tk.MustExec("begin pessimistic;")
tk.MustExec("insert into t(a) values (1);")
info := tk.Se.TxnInfo()
c.Assert(info.EntriesCount, Equals, uint64(1))
c.Assert(info.EntriesSize, Equals, uint64(29))
tk.MustExec("insert into t(a) values (2);")
info = tk.Se.TxnInfo()
c.Assert(info.EntriesCount, Equals, uint64(2))
c.Assert(info.EntriesSize, Equals, uint64(58))
tk.MustExec("commit;")
}

func (s *testTxnStateSuite) TestBlocked(c *C) {
tk := testkit.NewTestKitWithInit(c, s.store)
tk2 := testkit.NewTestKitWithInit(c, s.store)
tk.MustExec("create table t(a int);")
tk.MustExec("insert into t(a) values (1);")
tk.MustExec("begin pessimistic;")
tk.MustExec("select * from t where a = 1 for update;")
go func() {
tk2.MustExec("begin pessimistic")
tk2.MustExec("select * from t where a = 1 for update;")
tk2.MustExec("commit;")
}()
time.Sleep(100 * time.Millisecond)
c.Assert(tk2.Se.TxnInfo().State, Equals, txninfo.TxnLockWaiting)
c.Assert(tk2.Se.TxnInfo().BlockStartTime, NotNil)
tk.MustExec("commit;")
}

func (s *testTxnStateSuite) TestCommitting(c *C) {
tk := testkit.NewTestKitWithInit(c, s.store)
tk2 := testkit.NewTestKitWithInit(c, s.store)
tk.MustExec("create table t(a int);")
tk.MustExec("insert into t(a) values (1), (2);")
tk.MustExec("begin pessimistic;")
tk.MustExec("select * from t where a = 1 for update;")
ch := make(chan struct{})
go func() {
tk2.MustExec("begin pessimistic")
c.Assert(tk2.Se.TxnInfo(), NotNil)
tk2.MustExec("select * from t where a = 2 for update;")
failpoint.Enable("github.com/pingcap/tidb/session/mockSlowCommit", "sleep(200)")
defer failpoint.Disable("github.com/pingcap/tidb/session/mockSlowCommit")
tk2.MustExec("commit;")
ch <- struct{}{}
}()
time.Sleep(100 * time.Millisecond)
c.Assert(tk2.Se.TxnInfo().State, Equals, txninfo.TxnCommitting)
tk.MustExec("commit;")
<-ch
}

func (s *testTxnStateSuite) TestRollbacking(c *C) {
tk := testkit.NewTestKitWithInit(c, s.store)
tk.MustExec("create table t(a int);")
tk.MustExec("insert into t(a) values (1), (2);")
ch := make(chan struct{})
go func() {
tk.MustExec("begin pessimistic")
tk.MustExec("insert into t(a) values (3);")
failpoint.Enable("github.com/pingcap/tidb/session/mockSlowRollback", "sleep(200)")
defer failpoint.Disable("github.com/pingcap/tidb/session/mockSlowRollback")
tk.MustExec("rollback;")
ch <- struct{}{}
}()
time.Sleep(100 * time.Millisecond)
c.Assert(tk.Se.TxnInfo().State, Equals, txninfo.TxnRollingBack)
<-ch
}

func (s *testSessionSuite) TestReadDMLBatchSize(c *C) {
tk := testkit.NewTestKit(c, s.store)
tk.MustExec("set global tidb_dml_batch_size=1000")
se, err := session.CreateSession(s.store)
c.Assert(err, IsNil)
// `select 1` to load the global variables.
_, _ = se.Execute(context.TODO(), "select 1")
c.Assert(se.GetSessionVars().DMLBatchSize, Equals, 1000)
}
>>>>>>> 44830b917... session: fix dml_batch_size doesn't load the global variable (#24710)

0 comments on commit 9195081

Please sign in to comment.