Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plot buttons #74

Merged
merged 7 commits into from
Oct 25, 2017
Merged

Refactor plot buttons #74

merged 7 commits into from
Oct 25, 2017

Conversation

tiagofilipe12
Copy link
Owner

This PR refactored the functions associated with all plot buttons and implemented a sort button for alphabetical order.

It still lacks a way to sort by descending order of values. This needs a way to sort a list using a array with repeated entries. Example

// starting array
array = [a,b,a,b,c,c,d,c]

// final desired array
finalArray = [c,c,c,a,a,b,b,d]

@tiagofilipe12 tiagofilipe12 added this to the Paper milestone Oct 23, 2017
@tiagofilipe12 tiagofilipe12 self-assigned this Oct 23, 2017
@tiagofilipe12
Copy link
Owner Author

Now, descending order sorter is implemented for all plots but length plot (because it is not a categorical value but rather a continuum of values). Perhaps sorting length values does not make much sense and buttons should be hidden to avoid unnecessary overload.

Also, PR fixed the behavior of reset-sliders and taxaModalClear buttons.

TODO:

  • Check sort length plots (maybe there is no point in doing so).
  • Implement a loading information for plotly graph generation.

Repository owner deleted a comment Oct 24, 2017
@tiagofilipe12
Copy link
Owner Author

Fixed length plots sorting and greatly increased the speed of sorting plots by storing a list instead of querying again.

@tiagofilipe12 tiagofilipe12 merged commit cb4a143 into master Oct 25, 2017
@tiagofilipe12 tiagofilipe12 deleted the refactor_plot-buttons branch October 25, 2017 08:53
@tiagofilipe12 tiagofilipe12 added this to Done in Project board Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant