Fix specs for Rails 4 and get Travis CI to pass #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tiagogodinho please enable Travis CI for PRs to this repository. |
I've now added gemfiles for each of Rails versions 3.2, 4.0, 4.1, 4.2. In addition, there's a "master" version but Mongoid currently conflicts so it's set to Rails 4.2 and Mongoid master. I've moved /gemfiles to be /spec/gemfiles. Rails 3 specs are marked as "allowed failures" since the format has changed entirely. I've investigated and decided that it's not worth the effort to make both Rails 3 and 4 pass, but at least I've gotten to the point where the Rails 3 env build correctly and we can see the individual specs fail due to format change. I've also added coveralls as a dev dependency, otherwise Travis fails. Lastly, Travis CI does not require service: mongodb to pass hence I've removed it.
johnnyshields
changed the title
tiagogodinho
added a commit
that referenced
this pull request
May 8, 2015
Fix specs for Rails 4 and get Travis CI to pass
|
@johnnyshields: Great job. Congratulations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets Travis CI to pass for Rails 4.
I've added gemfiles for each of Rails versions 3.2, 4.0, 4.1, 4.2. In addition, there's a "master" version but Mongoid currently conflicts so it's set to Rails 4.2 and Mongoid master. I've moved /gemfiles to be /spec/gemfiles.
Rails 3 specs are marked as "allowed failures" since the output HTML format has changed entirely. I've investigated and decided that it's not worth the effort to make both Rails 3 and 4 pass, but at least I've gotten to the point where the Rails 3 env build correctly and we can see the individual specs fail due to format change.
I've also added coveralls as a dev dependency, otherwise Travis fails.
Lastly, Travis CI does not require service: mongodb to pass hence I've removed it.
You can see the passing build here: https://travis-ci.org/johnnyshields/localized_fields/builds/60084925