Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove console error when wrong length cpf #17

Merged

Conversation

ViniciusVieiraIME
Copy link
Contributor

Because of the console.error my app always broke when somebody entered a wrong length cpf, now it only returns false and I can deal with it on the app

@tiagoporto
Copy link
Owner

HI @ViniciusVieiraIME, thanks for the PR.

I would like to understand when you said my app always broke, since it's only a console message, could you explain what happen?

@ViniciusVieiraIME
Copy link
Contributor Author

ViniciusVieiraIME commented Aug 20, 2020 via email

@tiagoporto
Copy link
Owner

Interessante, não sabia.

Obrigado

@tiagoporto tiagoporto merged commit 3e8f37c into tiagoporto:master Aug 20, 2020
@tiagoporto tiagoporto changed the title Changed wrong length cpf validation return, from error to false Remove console error when wrong length cpf Aug 20, 2020
@tiagoporto
Copy link
Owner

@ViniciusVieiraIME version 5.0.1 available. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants