Patch 1 #350
Closed
Patch 1 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 3 apis to convert currency
Added interfaces props for convert functions
Added 4. Order status (USER_DATA) 5. Get Convert Trade History (USER_DATA)
added params for: 4. Order status (USER_DATA) 5. Get Convert Trade History (USER_DATA)
fixed capitalization for imported params
Various typos fixed
|
Hello @tiagosiebler there seems to be a problem with my merge request, could you give me a hand? |
|
@tiagosiebler Hello, could you give me a hand on why the circle test is not valid? |
src/main-client.ts
Outdated
Comment on lines
318
to
322
| acceptQuoteRequest( | ||
| params: EnableConvertSubAccountParams, | ||
| ): Promise<any>; { | ||
| return this.postPrivate('sapi/v1/convert/acceptQuote', params); | ||
| } |
There was a problem hiding this comment.
Typo here is breaking the build, should be:
Suggested change
| acceptQuoteRequest( | |
| params: EnableConvertSubAccountParams, | |
| ): Promise<any>; { | |
| return this.postPrivate('sapi/v1/convert/acceptQuote', params); | |
| } | |
| acceptQuoteRequest( | |
| params: EnableConvertSubAccountParams, | |
| ): Promise<any> { | |
| return this.postPrivate('sapi/v1/convert/acceptQuote', params); | |
| } |
src/main-client.ts
Outdated
Comment on lines
324
to
346
| enableConvertSubAccount( | ||
| params: AcceptQuoteRequestParams | ||
| ): Promise<any>; { | ||
| return this.postPrivate('sapi/v1/broker/subAccount/convert', params); | ||
| } | ||
|
|
||
| convertQuoteRequest( | ||
| params: ConvertQuoteRequestParams, | ||
| ): Promise<any>; { | ||
| return this.postPrivate('sapi/v1/convert/getQuote', params); | ||
| } | ||
|
|
||
| getOrderStatus( | ||
| params: GetOrderStatusParams, | ||
| ): Promise<any>; { | ||
| return this.getPrivate('sapi/v1/convert/orderStatus', params); | ||
| } | ||
|
|
||
| getConvertTradeHistory( | ||
| params: GetConvertTradeHistoryParams, | ||
| ): Promise<any>; { | ||
| return this.getPrivate('sapi/v1/convert/tradeFlow', params); | ||
| } |
|
Thank you very much for the corrections, I have made the requested changes
________________________________
De: Tiago ***@***.***>
Enviado: jueves, 27 de julio de 2023 11:15 a. m.
Para: tiagosiebler/binance ***@***.***>
Cc: Martin Pelaez ***@***.***>; Author ***@***.***>
Asunto: Re: [tiagosiebler/binance] Patch 1 (PR #350)
@tiagosiebler commented on this pull request.
________________________________
In src/main-client.ts<#350 (comment)>:
+ enableConvertSubAccount(
+ params: AcceptQuoteRequestParams
+ ): Promise<any>; {
+ return this.postPrivate('sapi/v1/broker/subAccount/convert', params);
+ }
+
+ convertQuoteRequest(
+ params: ConvertQuoteRequestParams,
+ ): Promise<any>; {
+ return this.postPrivate('sapi/v1/convert/getQuote', params);
+ }
+
+ getOrderStatus(
+ params: GetOrderStatusParams,
+ ): Promise<any>; {
+ return this.getPrivate('sapi/v1/convert/orderStatus', params);
+ }
+
+ getConvertTradeHistory(
+ params: GetConvertTradeHistoryParams,
+ ): Promise<any>; {
+ return this.getPrivate('sapi/v1/convert/tradeFlow', params);
+ }
Same for these
—
Reply to this email directly, view it on GitHub<#350 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2CW6CIRQVK6SSID3UB3RLDXSIWSHANCNFSM6AAAAAA2ZV3T4Q>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additional Information