Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwanted Swarmpit port 888 #51

Merged
merged 3 commits into from Aug 16, 2020
Merged

Conversation

inmishrar
Copy link
Contributor

@inmishrar inmishrar commented Jul 11, 2020

Added Notes i.e:-

NOTE:- If you get error "network "traefik-public" is declared as external, but could not be found. You need to create a swarm-scoped network before the stack is deployed
" then please create network by using this command docker network create --driver=overlay traefik-public then again run docker stack deploy -c swarmpit.yml swarmpit

Updated DNS url:-
https:// to https://:888

inmishrar and others added 3 commits Jul 11, 2020
Added Notes i.e:-

NOTE:- If you get error "network "traefik-public" is declared as external, but could not be found. You need to create a swarm-scoped network before the stack is deployed
" then please create network by using this command docker network create --driver=overlay traefik-public then again run docker stack deploy -c swarmpit.yml swarmpit

Updated DNS url:-
https://<your swarmpit domain> to https://<your swarmpit domain>:888
@tiangolo
Copy link
Owner

tiangolo commented Aug 16, 2020

Thanks for your interest and effort!

So, the note shouldn't be necessary as it starts with:

Follow this guide to integrate it in your Docker Swarm mode cluster deployed as described in DockerSwarm.rocks with a global Traefik HTTPS proxy.

And it expects the cluster to be deployed with a main Traefik load balancer as described in the first tutorials.

About the port 888, it actually shouldn't be there. And as you made me notice it, I added the fix for that in your PR.

Thanks!

@tiangolo tiangolo changed the title Updated Note & port number 888 Remove unwanted Swarmpit port 888 Aug 16, 2020
@tiangolo tiangolo merged commit 3890da2 into tiangolo:master Aug 16, 2020
1 check passed
@inmishrar
Copy link
Contributor Author

inmishrar commented Aug 16, 2020

Hi @tiangolo

Thank you for fixing the port number issue and merging my PR, appreciate your support.

Rest about Notes, Actually I struggled while doing that configuration so placed because might be other also would be facing same so atleast they can quickly see and look what they need to do. what you say ?

Regards,
Ravi Mishra

@tiangolo
Copy link
Owner

tiangolo commented Dec 9, 2020

Thanks, but I prefer to keep it simple, if I add notes for all the possible errors that could happen then it would be much bigger. So I prefer to have it as simple as possible and try to explain as clearly as possible each step, including the previous ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants