Remove unwanted Swarmpit port 888

[inmishrar]

Added Notes i.e:-

NOTE:- If you get error "network "traefik-public" is declared as external, but could not be found. You need to create a swarm-scoped network before the stack is deployed
" then please create network by using this command docker network create --driver=overlay traefik-public then again run docker stack deploy -c swarmpit.yml swarmpit

Updated DNS url:-
https:// to https://:888

[tiangolo]

Thanks for your interest and effort!

So, the note shouldn't be necessary as it starts with:

Follow this guide to integrate it in your Docker Swarm mode cluster deployed as described in DockerSwarm.rocks with a global Traefik HTTPS proxy.

And it expects the cluster to be deployed with a main Traefik load balancer as described in the first tutorials.

About the port 888, it actually shouldn't be there. And as you made me notice it, I added the fix for that in your PR.

Thanks! ☕

[inmishrar]

Hi @tiangolo

Thank you for fixing the port number issue and merging my PR, appreciate your support.

Rest about Notes, Actually I struggled while doing that configuration so placed because might be other also would be facing same so atleast they can quickly see and look what they need to do. what you say ?

Regards,
Ravi Mishra

[tiangolo]

Thanks, but I prefer to keep it simple, if I add notes for all the possible errors that could happen then it would be much bigger. So I prefer to have it as simple as possible and try to explain as clearly as possible each step, including the previous ones.