Add fix to scope propagation: Do not mutate incoming list.

tiangolo · Nov 11, 2022 · 2e47883 · 2e47883
1 parent df55372
commit 2e47883
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/fastapi/dependencies/utils.py b/fastapi/dependencies/utils.py
@@ -147,7 +147,7 @@ def get_sub_dependant(
     security_scopes = security_scopes or []
     if isinstance(depends, params.Security):
         dependency_scopes = depends.scopes
-        security_scopes.extend(dependency_scopes)
+        security_scopes = security_scopes + list(dependency_scopes)
     if isinstance(dependency, SecurityBase):
         use_scopes: List[str] = []
         if isinstance(dependency, (OAuth2, OpenIdConnect)):

diff --git a/tests/test_dependency_scopes.py b/tests/test_dependency_scopes.py
@@ -47,7 +47,6 @@ def recursive_scopes(dep=Security(dep3, scopes=["scope3"])):
 client = TestClient(app)
 
 
-@pytest.mark.xfail()
 # issue https://github.com/tiangolo/fastapi/issues/5623
 def test_recursive_scopes(mocks):
     """