Skip to content

Commit

Permalink
⬆️ Upgrade mypy and tweak internal type annotations (#5398)
Browse files Browse the repository at this point in the history
  • Loading branch information
tiangolo committed Sep 15, 2022
1 parent 823df88 commit 74ce220
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions fastapi/dependencies/utils.py
Expand Up @@ -426,22 +426,22 @@ def is_coroutine_callable(call: Callable[..., Any]) -> bool:
return inspect.iscoroutinefunction(call)
if inspect.isclass(call):
return False
call = getattr(call, "__call__", None)
return inspect.iscoroutinefunction(call)
dunder_call = getattr(call, "__call__", None)
return inspect.iscoroutinefunction(dunder_call)


def is_async_gen_callable(call: Callable[..., Any]) -> bool:
if inspect.isasyncgenfunction(call):
return True
call = getattr(call, "__call__", None)
return inspect.isasyncgenfunction(call)
dunder_call = getattr(call, "__call__", None)
return inspect.isasyncgenfunction(dunder_call)


def is_gen_callable(call: Callable[..., Any]) -> bool:
if inspect.isgeneratorfunction(call):
return True
call = getattr(call, "__call__", None)
return inspect.isgeneratorfunction(call)
dunder_call = getattr(call, "__call__", None)
return inspect.isgeneratorfunction(dunder_call)


async def solve_generator(
Expand Down
2 changes: 1 addition & 1 deletion fastapi/routing.py
Expand Up @@ -127,7 +127,7 @@ async def serialize_response(
if is_coroutine:
value, errors_ = field.validate(response_content, {}, loc=("response",))
else:
value, errors_ = await run_in_threadpool( # type: ignore[misc]
value, errors_ = await run_in_threadpool(
field.validate, response_content, {}, loc=("response",)
)
if isinstance(errors_, ErrorWrapper):
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Expand Up @@ -51,7 +51,7 @@ Documentation = "https://fastapi.tiangolo.com/"
test = [
"pytest >=7.1.3,<8.0.0",
"pytest-cov >=2.12.0,<4.0.0",
"mypy ==0.910",
"mypy ==0.971",
"flake8 >=3.8.3,<6.0.0",
"black == 22.3.0",
"isort >=5.0.6,<6.0.0",
Expand Down

0 comments on commit 74ce220

Please sign in to comment.