Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort config inconsistent between local and travis #38

Closed
euri10 opened this issue Feb 18, 2019 · 4 comments
Closed

isort config inconsistent between local and travis #38

euri10 opened this issue Feb 18, 2019 · 4 comments

Comments

@euri10
Copy link
Contributor

euri10 commented Feb 18, 2019

Describe the bug
if you run isort locally, it sorts the fastapi package as a 3rd party package, so once you push a branch on travis, isort there will fail
I think PyCQA/isort#541 (comment) describes it well

To Reproduce

Expected behavior
to run isort locally and have travis succeed without having to change fastapi import orders

Environment:

  • OS: debian buster
  • FastAPI Version [e.g. 0.3.0], get it with: 0.5.0
import fastapi
print(fastapi.__version__)
  • Python version, get it with:
python --version

Additional context
Add any other context about the problem here.

@euri10 euri10 added the bug Something isn't working label Feb 18, 2019
@euri10 euri10 mentioned this issue Feb 18, 2019
@tiangolo
Copy link
Owner

I'm sorry for the inconvenience, this was actually lack of documentation.

The trick is to install FastAPI in your local environment with:

flit install --symlink

that way isort can detect FastAPI as an installed package and sort all the files accordingly.

I just added contributing guidelines here that should help setting up the local environment:

https://fastapi.tiangolo.com/contributing/

@euri10
Copy link
Contributor Author

euri10 commented Feb 18, 2019

oO thanks for the hint, today I learnt something, will ditch that "fix" 🐢

@euri10 euri10 closed this as completed Feb 18, 2019
@tiangolo
Copy link
Owner

That actually bit me too at the first iterations 😬

@tiangolo tiangolo added question Question or problem answered reviewed and removed bug Something isn't working labels Feb 22, 2023
@tiangolo tiangolo changed the title [BUG] isort config inconsistent between local and travis isort config inconsistent between local and travis Feb 22, 2023
@tiangolo tiangolo reopened this Feb 28, 2023
@github-actions
Copy link
Contributor

Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs.

@tiangolo tiangolo reopened this Feb 28, 2023
Repository owner locked and limited conversation to collaborators Feb 28, 2023
@tiangolo tiangolo converted this issue into discussion #8336 Feb 28, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

2 participants