New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isort fix #40
Closed
Closed
Isort fix #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Starlette" Wrong branch This reverts commit 957d996.
pyproject support
so that it uses them
in the command as not sure travis reads it
…, fixes the discrepency between travis and local
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 105 105
Lines 2687 2690 +3
=====================================
+ Hits 2687 2690 +3
Continue to review full report at Codecov.
|
Thanks! Please check the comments in #38 |
Solved quite elegently by #38 (comment) |
Hehe thanks 😊 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #38
main changes are the following appart from all imports having been reorganized
that should let you run isort locally without any other cli flags if you got the latest version (develop) that supports reading pyproject.toml
test.sh command for travis reflects that config:
isort --multi-line=3 --trailing-comma --force-grid-wrap=0 --use-parentheses --line-width 88 --project fastapi --section-default=THIRDPARTY --recursive --check-only --diff
So now you can run isort locally and get same results after you push on travis 🤤
Can't be sure I haven't made mistakes 🐲