Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add websocket to APIRouter #100

Merged
merged 3 commits into from
Mar 24, 2019
Merged

Add websocket to APIRouter #100

merged 3 commits into from
Mar 24, 2019

Conversation

euri10
Copy link
Contributor

@euri10 euri10 commented Mar 24, 2019

fix for #98

@codecov
Copy link

codecov bot commented Mar 24, 2019 •
edited
Loading

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #100   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         113    114    +1     
  Lines        2780   2820   +40     
=====================================
+ Hits         2780   2820   +40
Impacted Files Coverage Δ
fastapi/routing.py 100% <100%> (ø) ⬆️
tests/test_ws_router.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16ca54...fcdf5aa. Read the comment docs.

tiangolo
tiangolo requested changes Mar 24, 2019
View reviewed changes
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

Thanks a lot for the effort.

Just a couple of small changes 😁

Pipfile.lock Outdated Show resolved Hide resolved
tests/test_ws_router.py Show resolved Hide resolved
@tiangolo tiangolo merged commit 6d77e2a into fastapi:master Mar 24, 2019
@tiangolo
Copy link
Member

Excellent job! Thank you @euri10!

@tiangolo tiangolo mentioned this pull request Mar 24, 2019
Closed
@euri10 euri10 deleted the websocket_apirouter branch March 25, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiangolo tiangolo tiangolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@euri10 @tiangolo