Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Urdu translation for docs/ur/docs/external-links.md and fix urdu issue in Add Urdu translation for docs/ur/docs/benchmarks.md #10046

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

🌐 Add Urdu translation for docs/ur/docs/external-links.md and fix urdu issue in Add Urdu translation for docs/ur/docs/benchmarks.md #10046

wants to merge 19 commits into from

Conversation

AhsanSheraz
Copy link
Contributor

No description provided.

@tiangolo
Copy link
Owner

tiangolo commented Aug 8, 2023

📝 Docs preview for commit b0efbaa at: https://3fc208db.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented Aug 8, 2023

📝 Docs preview for commit 641e549 at: https://8aa88612.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented Aug 8, 2023

📝 Docs preview for commit 1fa9c0e at: https://4b86ca05.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented Aug 8, 2023

📝 Docs preview for commit eaf69c8 at: https://c1c699fb.fastapitiangolo.pages.dev

@AhsanSheraz AhsanSheraz changed the title Add Urdu translation for docs/ur/docs/external-links.md and fix urdu issue in Add Urdu translation for docs/ur/docs/benchmarks.md` 🌐 Add Urdu translation for docs/ur/docs/external-links.md and fix urdu issue in Add Urdu translation for docs/ur/docs/benchmarks.md` Aug 8, 2023
@AhsanSheraz AhsanSheraz changed the title 🌐 Add Urdu translation for docs/ur/docs/external-links.md and fix urdu issue in Add Urdu translation for docs/ur/docs/benchmarks.md` 🌐 Add Urdu translation for docs/ur/docs/external-links.md and fix urdu issue in Add Urdu translation for docs/ur/docs/benchmarks.md Aug 8, 2023
@talhaumer
Copy link

Looks Good

@AhsanSheraz
Copy link
Contributor Author

@tiangolo Can you please add labels to this MR?

@tiangolo tiangolo added lang-all Translations awaiting-review lang-ur Urdu translations labels Aug 14, 2023
talhaumer
talhaumer approved these changes Aug 15, 2023
View reviewed changes
Copy link

@talhaumer talhaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@talhaumer
Copy link

Looks good

talhaumer
talhaumer approved these changes Aug 15, 2023
View reviewed changes
Copy link

@talhaumer talhaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

talha-softversum
talha-softversum approved these changes Aug 15, 2023
View reviewed changes
Copy link

@talha-softversum talha-softversum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

tiangolo
tiangolo reviewed Sep 2, 2023
View reviewed changes
docs/ur/docs/benchmarks.md Outdated Show resolved Hide resolved
talhaumer
talhaumer approved these changes Sep 6, 2023
View reviewed changes
Copy link

@talhaumer talhaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good

talhaumer
talhaumer approved these changes Oct 27, 2023
View reviewed changes
Copy link

@talhaumer talhaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good

tiangolo
tiangolo requested changes Oct 29, 2023
View reviewed changes
Copy link
Owner

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AhsanSheraz!

Now that the RTL bug is fixed, please remove all the extra style="direction: rtl;" and their divs. Thanks! ☕

@AhsanSheraz
Copy link
Contributor Author

AhsanSheraz commented Oct 29, 2023 •
edited

Thanks @AhsanSheraz!

Now that the RTL bug is fixed, please remove all the extra style="direction: rtl;" and their divs. Thanks! ☕

Removed @tiangolo

@tiangolo
Copy link
Owner

📝 Docs preview for commit 6929a70 at: https://86521267.fastapitiangolo.pages.dev

@AhsanSheraz
Copy link
Contributor Author

AhsanSheraz commented Oct 29, 2023 •
edited

@tiangolo everything is working well but we have to add this

style="text-align: right;"

because it is aligning to the left but it should be to the right, so adding this as well.
image

Now you see after adding the style text-align right make it like the below:
image

@tiangolo
Copy link
Owner

📝 Docs preview for commit 2b1c774 at: https://5ff66add.fastapitiangolo.pages.dev

@alejsdev alejsdev added p2 and removed investigate labels Jan 15, 2024
@tiangolo
Copy link
Owner

I just noticed that there was another CSS bug introduced by a previous RTL PR, I just fixed it here: #11039

Now with this, you can remove all the style="text-align: right;" blocks. 🤓

@tiangolo tiangolo added p4 and removed p2 labels Jan 28, 2024
@tiangolo
Copy link
Owner

📝 Docs preview for commit 6cebf05 at: https://05a3595f.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented Feb 4, 2024

📝 Docs preview for commit 82a9dd4 at: https://1e425d33.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented Feb 4, 2024

📝 Docs preview for commit 6c9362e at: https://28dd6e57.fastapitiangolo.pages.dev

AhsanSheraz
AhsanSheraz commented Feb 4, 2024
View reviewed changes
Copy link
Contributor Author

@AhsanSheraz AhsanSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed all the changes in this MR

@AhsanSheraz
Copy link
Contributor Author

I just noticed that there was another CSS bug introduced by a previous RTL PR, I just fixed it here: #11039

Now with this, you can remove all the style="text-align: right;" blocks. 🤓

@tiangolo Fixed all the changes in this MR related to `style="text-align: right;" divs and removed this from all the files.

aimasheraz1
aimasheraz1 approved these changes Feb 4, 2024
View reviewed changes
Copy link

@aimasheraz1 aimasheraz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now without style and div

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulemanhelp sulemanhelp sulemanhelp approved these changes

@talhaumer talhaumer talhaumer approved these changes

@talha-softversum talha-softversum talha-softversum approved these changes

@aimasheraz1 aimasheraz1 aimasheraz1 approved these changes

@tiangolo tiangolo Awaiting requested review from tiangolo

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ur Urdu translations p4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@AhsanSheraz @tiangolo @talhaumer @sulemanhelp @talha-softversum @aimasheraz1 @alejsdev