Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摑 Reword in docs, from "have in mind" to "keep in mind" #10376

Merged
merged 3 commits into from Jan 11, 2024

Conversation

malicious
Copy link
Contributor

"Keep in mind" is how you would express this in an imperative form.

First pass was done on macOS 10.15 with:

LC_ALL=C find docs -type f -exec sed -i '' 's/Have in mind/Keep in mind/g' '{}' +
LC_ALL=C find docs -type f -exec sed -i '' 's/have in mind/keep in mind/g' '{}' +
git restore docs/en/docs/img

"Keep in mind" is how you would express this in an imperative form.

First pass was done on macOS 10.15 with:

    LC_ALL=C find docs -type f -exec sed -i '' 's/Have in mind/Keep in mind/g' '{}' +
    LC_ALL=C find docs -type f -exec sed -i '' 's/have in mind/keep in mind/g' '{}' +
    git restore docs/en/docs/img
@tiangolo
Copy link
Owner

tiangolo commented Oct 3, 2023

馃摑 Docs preview for commit 5805b10 at: https://75293bc4.fastapitiangolo.pages.dev

@gregmuellegger
Copy link

As a non-native speaker I wondered if Have in mind is wrong, or what the difference is between the two.

The definition of have in mind:

To be considering someone or something as a candidate or possibility for something. In this usage, a noun or pronoun can be used between "have" and "in."

The definition of keep in mind:

Used to introduce something that one wants to emphasize or be remembered.

So I think both versions are valid, but the later fits the situations it is used in the documentation better.

Another random discussion in a language forum:

I think there is no difference in meaning between the three: "While doing AAA, (have/keep/bear) in mind BBB." All of them say "for the period of time you are doing AAA, also think about BBB, because it affects your understanding of AAA." All are good AE usage.

bear in mind is the most common. Here bear literally means carry. It is easy to imagine carrying BBB while doing AAA.

keep in mind is also common in this use. It has the concept of holding BBB while doing AAA.

have in mind is okay, but it could be a little bit confusing, only because to have something in mind (meaning "to already have your own ideas about the current topic") is such a common phrase.

Based on that information, I support that change.

Copy link

@gregmuellegger gregmuellegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @malicious! 馃

And thanks for the review @gregmuellegger 馃攳

@malicious, would you please implement the suggestions from @gregmuellegger?

@tiangolo tiangolo changed the title docs/en: Replace "have in mind" with "keep in mind" 馃摑 Reword in docs, from "have in mind" to "keep in mind" Oct 20, 2023
Found by searching docs for "in mind".
@tiangolo
Copy link
Owner

馃摑 Docs preview for commit d9f8b01 at: https://6975e493.fastapitiangolo.pages.dev

@tiangolo tiangolo added the docs Documentation about how to use FastAPI label Oct 30, 2023
@alejsdev
Copy link
Collaborator

Thank you! @malicious 馃

And thanks for the help too @gregmuellegger 馃樃

@alejsdev alejsdev enabled auto-merge (squash) January 11, 2024 16:29
@alejsdev alejsdev merged commit 838e9c9 into tiangolo:master Jan 11, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants