Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✏️ Fix typo in fastapi/routing.py #10520

Merged
merged 1 commit into from Jan 9, 2024
Merged

✏️ Fix typo in fastapi/routing.py #10520

merged 1 commit into from Jan 9, 2024

Conversation

sepsh
Copy link
Contributor

@sepsh sepsh commented Oct 25, 2023

No description provided.

@sepsh
Copy link
Contributor Author

sepsh commented Oct 25, 2023

@Kludex

@alejsdev alejsdev changed the title Fix: https://github.com/tiangolo/fastapi/discussions/10493 🌐 Fix typo in fastapi/routing.py Jan 9, 2024
@alejsdev alejsdev changed the title 🌐 Fix typo in fastapi/routing.py ✏️ Fix typo in fastapi/routing.py Jan 9, 2024
@alejsdev alejsdev changed the title ✏️ Fix typo in fastapi/routing.py ✏️ Fix typo in fastapi/routing.py Jan 9, 2024
@alejsdev alejsdev added the docs Documentation about how to use FastAPI label Jan 9, 2024
@alejsdev
Copy link
Collaborator

alejsdev commented Jan 9, 2024

Thanks for your help! @sepsh 😄

For future references: This is a fix for #10493

@tiangolo
Copy link
Owner

tiangolo commented Jan 9, 2024

Nice catch @sepsh! 🔍

Thanks for the reviews @Kludex, @hasansezertasan, @alejsdev ☕ 🍪 👋

@tiangolo tiangolo merged commit 60e1259 into tiangolo:master Jan 9, 2024
19 checks passed
@sepsh
Copy link
Contributor Author

sepsh commented Jan 9, 2024 •
edited

Thanks to your awesome work @Kludex @alejsdev @tiangolo @hasansezertasan. I'm glad I could help. 🤗✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

@hasansezertasan hasansezertasan hasansezertasan approved these changes

@alejsdev alejsdev alejsdev approved these changes

Assignees
No one assigned
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sepsh @alejsdev @tiangolo @Kludex @hasansezertasan