📝 Add warning about lifespan functions and backwards compatibility with events #10734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 Docs preview for commit a117d0e at: https://a824f295.fastapitiangolo.pages.dev |
|
📝 Docs preview for commit d432e56 at: https://c6dbf0de.fastapitiangolo.pages.dev |
|
@tiangolo This is my first time contributing to FastAPI. Is there anything else I need to do for this PR? |
|
📝 Docs preview for commit df51abb at: https://e35849a0.fastapitiangolo.pages.dev |
|
📝 Docs preview for commit 19db41c at: https://1d141478.fastapitiangolo.pages.dev |
alejsdev
changed the title
alejsdev
approved these changes
Jan 12, 2024
|
Good idea, thank you for your contribution @jacob-indigo! 🍰 ☕ |
nilslindemann
added a commit
to nilslindemann/fastapi
that referenced
this pull request
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards compatibility with
startup/shutdownevents in implemented in Starlette with a default lifespan function that calls the registered event handlers. If there is a user-provided lifespan function, those event handlers will no longer be called.