Fix exclude_unset and aliases in response model validation. #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Kilo59
reviewed
Mar 5, 2020
Kilo59
approved these changes
Mar 22, 2020
|
Excellent job @juhovh-aiven ! 👏 🤓 Thanks for your contribution! 🍰 🚀 And thanks @Kilo59 for the review 🤓 🕵️♂️ 🔍 |
hyahiaoui
pushed a commit
to hyahiaoui/fastapi
that referenced
this pull request
Aug 1, 2020
…o#1074) * Fix exclude_unset and aliases in response model validation. * ✨ Use by_alias from param 🤷 Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix both #1043 and #1063, but might come with some performance penalty since unnecessary serialization is being done. Better solutions that pass the given tests are more than welcome, but I don't see a much better way other than recursion in cases where there are models inside basic data structures like lists and dicts.