Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add German translation for docs/de/docs/how-to/index.md #10769

Merged
merged 6 commits into from Mar 30, 2024

Conversation

nilslindemann
Copy link
Contributor

@nilslindemann nilslindemann commented Dec 8, 2023

← deployment/docker.md (#10759)
β†’ how-to/general.md (#10770)

German translation progress

* Full translation
* In sync with current docs/en/docs/how-to/index.md
* Google Translate used
* Manually checked
* Checked for errors using LanguageTool
@nilslindemann
Copy link
Contributor Author

@tiangolo It seems that squidfunk/mkdocs-material-insiders is now squidfunk/mkdocs-material – the author has removed the -insiders from the name of the repository. Therefore the tests fail:

Collecting git+https://****@github.com/squidfunk/mkdocs-material-insiders.git
  Cloning https://****@github.com/squidfunk/mkdocs-material-insiders.git to /tmp/pip-req-build-wc0ck37j
  Running command git clone --filter=blob:none --quiet 'https://****@github.com/squidfunk/mkdocs-material-insiders.git' /tmp/pip-req-build-wc0ck37j
  fatal: could not read Username for 'https://github.com/': No such device or address

This reverts commit 156350449841fa015bc96eeff0718f1dd795307b.
@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 4c661ac at: https://d4539440.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 2cf3065 at: https://5e54e649.fastapitiangolo.pages.dev

@nilslindemann
Copy link
Contributor Author

nilslindemann commented Dec 16, 2023

@tiangolo the coverage test fails (99% < 100%). The function __get_pydantic_core_schema__ in fastapi/openapi/models.py has no coverage.

Edit: Ok, it creates the preview πŸ‘

@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 51e309a at: https://68215d3a.fastapitiangolo.pages.dev

@alejsdev alejsdev added lang-all Translations awaiting-review lang-de German translations labels Jan 8, 2024
@tiangolo tiangolo merged commit 57a7579 into tiangolo:master Mar 30, 2024
41 checks passed
@tiangolo
Copy link
Owner

Awesome @nilslindemann! πŸš€

As you are the champion of German translations and you have done so many, and with so much attention to detail, I'm gonna go ahead and merge this. πŸŽ‰

If others see things that could be improved later, we can check that in new PRs. πŸ€“

@nilslindemann nilslindemann deleted the de/docs/how-to/index.md branch April 1, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-all Translations lang-de German translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants