Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add German translation for docs/de/docs/benchmarks.md #10866

Merged
merged 5 commits into from Jan 23, 2024
Merged

🌐 Add German translation for docs/de/docs/benchmarks.md #10866

merged 5 commits into from Jan 23, 2024

Conversation

nilslindemann
Copy link
Contributor

@nilslindemann nilslindemann commented Dec 30, 2023 •
edited

← history-design-future.md (#10865)
→ help/index.md (#10497)
→ help-fastapi.md (#10455)

German translation progress

@nilslindemann
🌐 Add German translation for docs/de/docs/benchmarks.md
357f3b7 
* Full translation
* In sync with current docs/en/docs/benchmarks.md
* Google Translate used
* Manually checked
* Checked for errors using LanguageTool
This was referenced Dec 30, 2023
Merged
Merged
@tiangolo
Copy link
Owner

📝 Docs preview for commit 357f3b7 at: https://af5218da.fastapitiangolo.pages.dev

@nilslindemann nilslindemann mentioned this pull request Dec 30, 2023
Merged
@alejsdev alejsdev added lang-all Translations awaiting-review lang-de German translations labels Jan 8, 2024
@tiangolo
Copy link
Owner

📝 Docs preview for commit b01bbd7 at: https://5d2936c4.fastapitiangolo.pages.dev

dpinezich
dpinezich reviewed Jan 15, 2024
View reviewed changes
Copy link

@dpinezich dpinezich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Added some points for simplicity.

@nilslindemann
Copy link
Contributor Author

Danke @dpinezich fürs Review!

@tiangolo
Copy link
Owner

📝 Docs preview for commit b181a47 at: https://31546f90.fastapitiangolo.pages.dev

dpinezich
dpinezich approved these changes Jan 23, 2024
View reviewed changes
Copy link

@dpinezich dpinezich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🚀👏

@alejsdev alejsdev merged commit dcf8b24 into tiangolo:master Jan 23, 2024
41 checks passed
@alejsdev
Copy link
Collaborator

Thanks for the help! @nilslindemann 🤓

And thanks for the review @dpinezich 🚀

@nilslindemann
Copy link
Contributor Author

Danke sehr!

@nilslindemann nilslindemann deleted the de/docs/benchmarks.md branch January 23, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpinezich dpinezich dpinezich approved these changes

Assignees
No one assigned
Labels
approved-1 lang-all Translations lang-de German translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nilslindemann @tiangolo @alejsdev @dpinezich