Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Update Russian translation of docs/ru/docs/alternatives.md #10964

Closed
wants to merge 9 commits into from

Conversation

s111d
Copy link
Contributor

@s111d s111d commented Jan 13, 2024

Completely retranslated and corrected russian page of alternatives.md in docs. Several errors were found and fixed.

@tiangolo
Copy link
Owner

📝 Docs preview for commit 4877b21 at: https://c324ba00.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit f15ed97 at: https://3df03451.fastapitiangolo.pages.dev

Copy link
Contributor

@Jamim Jamim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @s111d,

Thanks for your effort! To be honest, I didn't read the whole reworked document yet, but one sentence at the end captured my attention, so I'd like to suggest a minor change.

docs/ru/docs/history-design-future.md Outdated Show resolved Hide resolved
@tiangolo
Copy link
Owner

📝 Docs preview for commit afe041c at: https://525c072a.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit 3896574 at: https://acff2457.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

Thanks @s111d! It would be better to separate this PR into multiple PRs, one per file. That way it's easier for others to review/approve.

@s111d
Copy link
Contributor Author

s111d commented Jan 14, 2024

Thanks @s111d! It would be better to separate this PR into multiple PRs, one per file. That way it's easier for others to review/approve.

Totally agree, my bad. Will split it a little later.

@alejsdev alejsdev added lang-all Translations lang-ru Russian translations awaiting-review labels Jan 14, 2024
@tiangolo tiangolo changed the title Russian alternatives.md page reworked 🌐 Update Russian translation of docs/ru/docs/alternatives.md Jan 14, 2024
@tiangolo
Copy link
Owner

tiangolo commented Apr 2, 2024

@s111d, could you please split this into 3 PRs, one for each file? That way it would be easier to review, approve, and merge. 🤓

@tiangolo
Copy link
Owner

tiangolo commented May 3, 2024

As this PR had requested changes to be applied but has been inactive for a while, it's now going to be closed. But if there's anyone interested, feel free to create a new PR.

@tiangolo tiangolo closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants