Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for docs/ko/docs/features.md #10976

Merged
merged 4 commits into from Jan 23, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/features.md #10976

merged 4 commits into from Jan 23, 2024

Conversation

KaniKim
Copy link
Contributor

@KaniKim KaniKim commented Jan 16, 2024

  • Add Korean translation for docs/ko/docs/features.md
  • I mistaken git push, sorry for my mistake.

@tiangolo
Copy link
Owner

📝 Docs preview for commit dc79e88 at: https://2c945df8.fastapitiangolo.pages.dev

@alejsdev alejsdev added lang-all Translations awaiting-review lang-ko Korean translations labels Jan 16, 2024
hard-coders
hard-coders suggested changes Jan 17, 2024
View reviewed changes
Copy link
Sponsor Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great effort! 🎉
I looked over some untranslated and typos, so please take a look.

docs/ko/docs/features.md Outdated Show resolved Hide resolved
docs/ko/docs/features.md Outdated Show resolved Hide resolved
docs/ko/docs/features.md Outdated Show resolved Hide resolved
docs/ko/docs/features.md Outdated Show resolved Hide resolved
docs/ko/docs/features.md Outdated Show resolved Hide resolved
docs/ko/docs/features.md Outdated Show resolved Hide resolved
docs/ko/docs/features.md Outdated Show resolved Hide resolved
@tiangolo
Copy link
Owner

📝 Docs preview for commit e05bf4b at: https://b36954e0.fastapitiangolo.pages.dev

hard-coders
hard-coders approved these changes Jan 17, 2024
View reviewed changes
Copy link
Sponsor Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tiangolo
Copy link
Owner

📝 Docs preview for commit a68914c at: https://53dd1e53.fastapitiangolo.pages.dev

@KaniKim KaniKim mentioned this pull request Jan 21, 2024
Merged
@alejsdev alejsdev merged commit 058044f into tiangolo:master Jan 23, 2024
42 checks passed
@alejsdev
Copy link
Collaborator

Thank you! @KaniKim 🙇‍♀️

And thanks for the review @hard-coders 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hard-coders hard-coders hard-coders approved these changes

Assignees
No one assigned
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KaniKim @tiangolo @alejsdev @hard-coders