Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/ko/docs/tutorial/dependencies/index.md #10989

Merged
merged 7 commits into from Jan 27, 2024

Conversation

KaniKim
Copy link
Contributor

@KaniKim KaniKim commented Jan 18, 2024

@tiangolo
Copy link
Owner

📝 Docs preview for commit cc06e3d at: https://2cd29979.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit f9d48d8 at: https://66197e59.fastapitiangolo.pages.dev

Copy link

@KimJoonSeo KimJoonSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some changes to make the sentences more clear.

docs/ko/docs/tutorial/dependencies/index.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/index.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/index.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/index.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/index.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/index.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/index.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/index.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/index.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/index.md Outdated Show resolved Hide resolved
@KaniKim
Copy link
Contributor Author

KaniKim commented Jan 27, 2024

I did some changes to make the sentences more clear.

Thank you for your suggestions, I changed it, please check it if you can.

@tiangolo
Copy link
Owner

📝 Docs preview for commit 3d74851 at: https://34b2bcbf.fastapitiangolo.pages.dev

@alejsdev alejsdev merged commit 00395f3 into tiangolo:master Jan 27, 2024
43 checks passed
@alejsdev
Copy link
Collaborator

Thank you! @KaniKim 🎉

And thanks for your review @KimJoonSeo 🧐🔍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants