Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade version of Starlette to >= 0.36.3 #11086

Merged
merged 2 commits into from Feb 4, 2024
Merged

Conversation

tiangolo
Copy link
Owner

@tiangolo tiangolo commented Feb 3, 2024

⬆️ Upgrade version of Starlette to >= 0.36.3

@tiangolo tiangolo changed the title ⬆️ Upgrade version of Starlette to >= 0.36.2 ⬆️ Upgrade version of Starlette to >= 0.36.3 Feb 4, 2024
@tiangolo tiangolo enabled auto-merge (squash) February 4, 2024 21:12
@tiangolo tiangolo merged commit 4a2be2a into master Feb 4, 2024
19 checks passed
@tiangolo tiangolo deleted the upgrade-starlette branch February 4, 2024 21:14
@tvasenin
Copy link

tvasenin commented Feb 10, 2024

@tiangolo There was an unintentionally breaking change that affected Starlette from v0.36.0 to v0.37.0.

Fixed in v0.37.1: encode/starlette#2485

Could you pls bump requiremens to starlette>=0.31.7 and release FastAPI v0.109.3?

@alimcmaster1
Copy link

I agree - #11146

@tvasenin - what is the Starlette API deprecation policy. Wondering if we need a max version

@tvasenin
Copy link

I agree - #11146

@tvasenin - what is the Starlette API deprecation policy. Wondering if we need a max version

I'm not aware of Starlette deprecation policy -- though, given the v0.x version scheme, according to SemVer, anything could happen in any release :)

@tvasenin
Copy link

Newly released v0.110.0 still has the old dependency -- here's PR #11320 to finally fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants