Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I came across a bug with setting the
root_path
value directly into theFastAPI
app. The docs state:But that wasn't the case since providing the
--root-path
option to Uvicorn or Hypercorn makes it so that the scope'spath
andraw_path
contain theroot_path
. The behavior in FastAPI was to patch the scope'sroot_path
value only, leaving thepath
andraw_path
unchanged.When running behind a proxy, this would cause the 307 redirect on missing trailing slashes to set the
Location
header to the path without theroot_path
value, resulting in a 404 error.