Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename a function in tutorial #1121

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Rename a function in tutorial #1121

merged 1 commit into from
Mar 27, 2020

Conversation

tmsick
Copy link
Contributor

@tmsick tmsick commented Mar 16, 2020

Path Parameters - FastAPI

from fastapi import FastAPI

app = FastAPI()


@app.get("/files/{file_path:path}")
async def read_user_me(file_path: str):
    return {"file_path": file_path}

I changed the name of the above function from read_user_me to read_file.

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #1121 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          223       223           
  Lines         6642      6642           
=========================================
  Hits          6642      6642           
Impacted Files Coverage Δ
...test_tutorial/test_path_params/test_tutorial004.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38fd8a6...92ed30c. Read the comment docs.

@tiangolo tiangolo merged commit 15241b5 into tiangolo:master Mar 27, 2020
@tiangolo
Copy link
Owner

Ah! Good catch. Thanks! 🚀 🍰

hyahiaoui pushed a commit to hyahiaoui/fastapi that referenced this pull request Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants