Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Upgrade Starlette to >=0.37.2,<0.38.0, remove Starlette filterwarning for internal tests #11266

Merged
merged 4 commits into from
Apr 2, 2024
Merged

⬆️ Upgrade Starlette to >=0.37.2,<0.38.0, remove Starlette filterwarning for internal tests #11266

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
241ef87
:arrow_up: Upgrade Starlette to >=0.37.0,<0.38.0
nothielf Mar 10, 2024
e9a30b8
:wrench: Remove starlette method param filterwarning
nothielf Mar 10, 2024
5bbaa98
:arrow_up: Upgrade Starlette to >=0.37.2,<0.38.0
nothielf Mar 19, 2024
b6f695a
Merge branch 'master' into master
nothielf Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ classifiers = [
"Topic :: Internet :: WWW/HTTP",
]
dependencies = [
"starlette>=0.36.3,<0.37.0",
"starlette>=0.37.2,<0.38.0",
Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good?

Suggested change
"starlette>=0.37.2,<0.38.0",
"starlette>=0.36.3,<0.38.0",

Copy link

@tvasenin tvasenin Mar 25, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, minimal version should NOT be less than 0.37.2, as it fixes DeprecationWarning described in the first post.
Also, 0.37.1 fixes another, very important regression: see #11320.

"pydantic>=1.7.4,!=1.8,!=1.8.1,!=2.0.0,!=2.0.1,!=2.1.0,<3.0.0",
"typing-extensions>=4.8.0",
]
Expand Down Expand Up @@ -121,9 +121,6 @@ filterwarnings = [
# - https://github.com/mpdavis/python-jose/issues/332
# - https://github.com/mpdavis/python-jose/issues/334
'ignore:datetime\.datetime\.utcnow\(\) is deprecated and scheduled for removal in a future version\..*:DeprecationWarning:jose',
# TODO: remove after upgrading Starlette to a version including https://github.com/encode/starlette/pull/2406
# Probably Starlette 0.36.0
"ignore: The 'method' parameter is not used, and it will be removed.:DeprecationWarning:starlette",
]

[tool.coverage.run]
Expand Down