Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摑 Tweak docs and translations links, typos, format #11389

Merged
merged 37 commits into from Apr 18, 2024

Conversation

nilslindemann
Copy link
Contributor

@nilslindemann nilslindemann commented Apr 1, 2024

Regeneration of #10985 minus ambiguous changes, which I outsource to #11390. It should now be easier to review. All changes here are unambiguous improvements.

The affected files are `index.md`, `features.md`, `fastapi-people.md`, under `docs/<lang>/docs/`. The changes are all the same.
The affected files are `docs/<langname>/docs/index.md`. All the same changes.
Has no effect regarding the link target, but syncs the syntax with other links in the docs.
Like previous commit.
Like previous commit.
My linkchecker script suggested them. I also compared the link target of the translation and the related English target side by side, to check that translated hash is correct.
Also translated the link text in tutorial/first-steps.md, according to the related target heading.
Also translated the link text in tutorial/first-steps.md, according to the related target heading.
The target heading changed in the English docs. The linkchecker script also reported these, and I checked manually.
Invalid hashes added in translations. Also reported by the linkchecker and manually tested.
This is automatically done by Mkdocs, so these manual anchors are not needed.
The same hash is also used in other occurences of that link.
Other local links under advanced/ also have that syntax. The link may now also automatically point to the translated page.
It's JavaScript, not Python.
The target code file has changed.
These boxes are often misunderstood in translations. I also did translate the keywords in the beginning.

The syntax is "!!! " followed by <keyword>, optionally followed by " " <translation>

<keyword> is required and is one of "info|note|tip|check|warning|danger". It defines the coloring of the info box. When it was missing, I added it, checking the related English .md.

<translation> may come after <keyword> and is inside of "". If the translation was available, I added it.

A global search under docs/ in VS Code with the regex "!!! (?!tip|warning|info|danger|note|check)" shows info boxes which do not comply to this scheme.

I left the invalid boxes under docs/fa/unchanged, because this is a right to left language and I am unsure how to write it there.
@tiangolo
Copy link
Owner

tiangolo commented Apr 1, 2024

馃摑 Docs preview for commit beef2fb at: https://d1be5c2a.fastapitiangolo.pages.dev

@alejsdev alejsdev added the docs Documentation about how to use FastAPI label Apr 2, 2024
@tiangolo
Copy link
Owner

馃摑 Docs preview for commit f502f51 at: https://063f9634.fastapitiangolo.pages.dev

@tiangolo tiangolo changed the title Doc improvements 馃摑 Tweak docs and translations links, typos, format Apr 18, 2024
@tiangolo
Copy link
Owner

馃摑 Docs preview for commit e613636 at: https://9fc802bb.fastapitiangolo.pages.dev

@tiangolo tiangolo merged commit ebc8ac7 into tiangolo:master Apr 18, 2024
43 checks passed
@tiangolo
Copy link
Owner

Nice, thank you @nilslindemann! 馃殌 馃嵃

@nilslindemann
Copy link
Contributor Author

Dito @tiangolo, thank you.

@nilslindemann nilslindemann deleted the doc-improvements branch April 20, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants