Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Use in memory database for testing SQL in docs #1223

Merged
merged 8 commits into from Jun 22, 2023

Conversation

HarshaLaxman
Copy link
Contributor

Useful for me, maybe it is better as just a note?

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cf73051) 100.00% compared to head (a608d9c) 100.00%.

❗ Current head a608d9c differs from pull request most recent head 65f4c3a. Consider uploading reports for the commit 65f4c3a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1223   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          540       540           
  Lines        13969     13952   -17     
=========================================
- Hits         13969     13952   -17     
Impacted Files Coverage Δ
...cs_src/sql_databases/sql_app/tests/test_sql_app.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/en/docs/advanced/testing-database.md Outdated Show resolved Hide resolved
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 010c79e at: https://611d964aa5127c2596f97561--fastapi.netlify.app

@eboddington
Copy link

I think this would be helpful to merge, or at least to have as a side note. I've wasted a while trying to get an in-memory database working for tests, only to find this and realise that I was missing poolclass=StaticPool!

@github-actions
Copy link
Contributor

📝 Docs preview for commit a608d9c at: https://631e1417f19e9b4d81e04ac7--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 7b88da9 at: https://639cc814c1ba730cfd259b2e--fastapi.netlify.app

@davidhammaker
Copy link

I don't know whether this will be merged (seems to be open still?), but it has helped me. It saves a lot of clean up during and after tests.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

📝 Docs preview for commit d56574f at: https://645157b86dc7d82ca6b38e85--fastapi.netlify.app

@HarshaLaxman
Copy link
Contributor Author

@tiangolo would you like to merge?

@tiangolo tiangolo changed the title Using in memory database for testing docs 📝 Use in memory database for testing SQL in docs Jun 22, 2023
@tiangolo
Copy link
Owner

Thanks @HarshaLaxman! 🚀

I've been wanting to update the docs about SQL to use SQLModel and re-use a bunch of those docs there. But for now, I'll take this. 🤓

And thanks everyone else for the comments and for letting me know that this is useful to you! 🍰

@tiangolo tiangolo enabled auto-merge (squash) June 22, 2023 11:17
@tiangolo tiangolo merged commit 2cef119 into tiangolo:master Jun 22, 2023
11 checks passed
@tiangolo tiangolo added the p4 label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants