Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for - [FEATURE] Remove *, where it's not needed #1234 #1239

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

pankaj-giri
Copy link
Contributor

Removed * from function parameters in the docs wherever not required. Please take a look and let me know if it looks good.

@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #1239 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1239   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          226       230    +4     
  Lines         6785      6862   +77     
=========================================
+ Hits          6785      6862   +77     
Impacted Files Coverage Δ
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
...test_tutorial/test_path_params/test_tutorial005.py 100.00% <0.00%> (ø)
tests/test_deprecated_openapi_prefix.py 100.00% <0.00%> (ø)
...orial/test_conditional_openapi/test_tutorial001.py 100.00% <0.00%> (ø)
...t_tutorial/test_behind_a_proxy/test_tutorial002.py 100.00% <0.00%> (ø)
...t_tutorial/test_behind_a_proxy/test_tutorial001.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f3ca1...479a6a0. Read the comment docs.

@tiangolo tiangolo merged commit 7e25183 into fastapi:master Jun 12, 2020
@tiangolo
Copy link
Member

Awesome, thanks for your contribution! 🚀 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants