Bugfix for duplicated headers from indirect dependencies #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lve_dependencies` only if necessary; fix formatting of scottsmith2gmail's test
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 226 227 +1
Lines 6785 6800 +15
=========================================
+ Hits 6785 6800 +15
Continue to review full report at Codecov.
|
|
Awesome! Great job debugging that 🐛 🕵️ 🔍 And thanks @scottsmith2gmail for discovering the problem and writing the tests ✔️ 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses the issue discovered by @scottsmith2gmail in #1385 and adds the test he proposed