🐛 Fix Enum handling with their own schema definitions #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://5ec95445c16d84aabe50dee3--fastapi.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 227 227
Lines 6807 6810 +3
=========================================
+ Hits 6807 6810 +3
Continue to review full report at Codecov.
|
nmarusov
added a commit
to nmarusov/AppFollow
that referenced
this pull request
Jul 12, 2020
hyahiaoui
pushed a commit
to hyahiaoui/fastapi
that referenced
this pull request
Aug 1, 2020
* 🐛 Fix extra support for enum with its own schema * ✅ Fix/update test for enum with its own schema * 🐛 Fix type declarations * 🔧 Update format and lint scripts to support locally installed Pydantic and Starlette * 🐛 Add temporary type ignores while enum schemas are merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Fix Enum handling with their own schema definitions.
I missed an error in #1461 , the story is a bit more complex. This currently breaks Swagger UI when using enums in other parts apart from bodies (e.g. path params).
It's necessary to add enums to the whole handling with OpenAPI of models to include the new definition in the components.
These changes plus a couple of updates in pydantic/pydantic#1432 work correctly in Swagger UI and generate an independent schema for enums (which was the original intention).