-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Japanese translation for tutorial/first-steps.md #1658
🌐 Add Japanese translation for tutorial/first-steps.md #1658
Conversation
…/ryuckel/fastapi into feature/add-japanese-translation
Codecov Report
@@ Coverage Diff @@
## master #1658 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 239 239
Lines 7079 7079
=========================================
Hits 7079 7079 Continue to review full report at Codecov.
|
I checked Japanese translation. I have no proposal of change about this document. Thank you so much! |
📝 Docs preview for commit 2250eb7 at: https://5f37d173c3f45f090fe0dc44--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's almost perfect!
I was wondering about some of the details, so if you would like to correct them, please do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be better to abstract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's so much better!
📝 Docs preview for commit 3007ed1 at: https://5f381722c3f45f1723e0d931--fastapi.netlify.app |
…nslation/japanese-tutorial-first-steps
📝 Docs preview for commit 4c0a572 at: https://5f4a708046d5ad4319178f04--fastapi.netlify.app |
Hi, @tiangolo |
This PR translates the tutorial/first-steps.md to Japanese.
Please review tutorial/first-steps.md.
Issue #1571 generates a new directory to support Japanese.I will fix dependency after #1571 is merged.