Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for tutorial/first-steps.md #1658

Merged

Conversation

tokusumi
Copy link
Contributor

@tokusumi tokusumi commented Jun 30, 2020

This PR translates the tutorial/first-steps.md to Japanese.
Please review tutorial/first-steps.md.

Issue #1571 generates a new directory to support Japanese.
I will fix dependency after #1571 is merged.

@tokusumi tokusumi mentioned this pull request Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #1658 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1658   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e1a26...54c7674. Read the comment docs.

@ryuckel
Copy link
Contributor

ryuckel commented Jul 3, 2020

I checked Japanese translation. I have no proposal of change about this document. Thank you so much!

@tiangolo tiangolo added lang-all Translations lang-ja Japanese translations awaiting-review labels Jul 10, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit 2250eb7 at: https://5f37d173c3f45f090fe0dc44--fastapi.netlify.app

Copy link
Contributor

@SwftAlpc SwftAlpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost perfect!
I was wondering about some of the details, so if you would like to correct them, please do so.

docs/ja/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/first-steps.md Show resolved Hide resolved
docs/ja/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/first-steps.md Show resolved Hide resolved
docs/ja/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SwftAlpc SwftAlpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be better to abstract.

docs/ja/docs/tutorial/first-steps.md Show resolved Hide resolved
Copy link
Contributor

@SwftAlpc SwftAlpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's so much better!

@github-actions
Copy link
Contributor

📝 Docs preview for commit 3007ed1 at: https://5f381722c3f45f1723e0d931--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 4c0a572 at: https://5f4a708046d5ad4319178f04--fastapi.netlify.app

@tokusumi
Copy link
Contributor Author

Hi, @tiangolo
This PR has been approved by two reviewers (github actions to label approved PR didn't work, though).
Would you like to require something more for this to be merged?

@tiangolo tiangolo merged commit 5c6811c into fastapi:master Oct 17, 2020
@tiangolo tiangolo changed the title Add Japanese translation for tutorial/first-steps.md 🌐 Add Japanese translation for tutorial/first-steps.md Oct 17, 2020
@tiangolo
Copy link
Member

Excellent! Thank you for doing it @tokusumi ! 🙇 🍰

And thanks @ryuckel and @SwftAlpc for the reviews 👏 👏 🤓

@tokusumi tokusumi deleted the translation/japanese-tutorial-first-steps branch January 18, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants