Updates starlette dependency to 0.13.6 due to vulnerability in 0.13.4 #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1759 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 235 235
Lines 6989 6989
=========================================
Hits 6989 6989 Continue to review full report at Codecov.
|
Kludex
approved these changes
Jul 21, 2020
|
Great, thank you! @jamesag26 ! 🎉 🍰 This is available in FastAPI |
3 tasks
hyahiaoui
pushed a commit
to hyahiaoui/fastapi
that referenced
this pull request
Aug 1, 2020
Co-authored-by: jalfordgolojuch <jalfordgolojuch@activecampaign.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project has Starlett dependency of version 0.13.4 which has a directory traversal vulnerability for windows machines. I was made aware of this through: https://snyk.io/vuln/SNYK-PYTHON-STARLETTE-573266
This upgrade would mostly be for the fix to this vulnerability that was introduced in Starlette 0.13.5. This upgrade would be to version 0.13.6 because version 0.13.6 fixes a breaking change related to how 0.13.5 was initially implemented.
Here is a link to the Starlett issue that was fixed for more details: encode/starlette#981