Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📌 Pin Swagger UI #1763

Merged
merged 1 commit into from
Jul 22, 2020
Merged

📌 Pin Swagger UI #1763

merged 1 commit into from
Jul 22, 2020

Conversation

tiangolo
Copy link
Member

📌 Pin Swagger UI while this is fixed: swagger-api/swagger-ui#6249

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #1763 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1763   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          235       235           
  Lines         6989      6989           
=========================================
  Hits          6989      6989           
Impacted Files Coverage Δ
fastapi/openapi/docs.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a2135...16d16ee. Read the comment docs.

@github-actions github-actions bot temporarily deployed to commit July 22, 2020 06:17 Inactive
@github-actions
Copy link
Contributor

@tiangolo tiangolo merged commit dadd665 into master Jul 22, 2020
@tiangolo tiangolo deleted the pin-swagger-ui branch July 22, 2020 06:19
@codefather-labs
Copy link

it's a problem of fastapi or swagger ui?

@Kludex
Copy link
Member

Kludex commented Jul 22, 2020

Is a Swagger issue, not FastAPI.

@tiangolo
Copy link
Member Author

Yep, it's a Swagger UI issue, not FastAPI.

But to alleviate the problem on the FastAPI side, I pinned it here and released it in FastAPI version 0.60.1, check the conversation here: #1762 (comment)

@kiennguyen1101
Copy link

Swagger UI released a new version to fix this issue:

New release to resolve this issue, v3.30.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.30.1 breaks path tags (endpoints don’t expand)
4 participants